Re: [PATCH RFC 4/5] kdbus: handle WARN_ON cases properly when decrementing quota

From: Sergei Zviagintsev
Date: Thu Jul 02 2015 - 06:28:01 EST


Hi,

On Thu, Jul 02, 2015 at 10:37:05AM +0200, David Herrmann wrote:
> Hi
>
> On Sun, Jun 28, 2015 at 3:17 PM, Sergei Zviagintsev <sergei@xxxxxxxx> wrote:
> > If we spotted inconsistency, fix it by setting values to zero.
>
> Why?
>
> I prefer doing nothing and just bailing out on programming errors.
> Setting it to 0 just complicates debugging and drops possibly useful
> information ('what was the counter value at that time?').

Thank you for commenting on this! Now it seems to be clear for me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/