Re: [PATCH v2] regulator: wm831x-dcdc: Use pointer after NULL check

From: Mark Brown
Date: Thu Jul 02 2015 - 07:34:09 EST


On Thu, Jul 02, 2015 at 12:19:50PM +0100, Charles Keepax wrote:
> On Thu, Jul 02, 2015 at 12:14:56PM +0100, Mark Brown wrote:

> > It's a bug - either the validation shouldn't be there or it needs to be
> > before the use otherwise it does nothing.

> ARRAY_SIZE being implemented with sizeof's means that no actual
> dereference takes place. But if we have multiple people thinking
> this looks buggy then I guess the code probably isn't clear
> enough at the moment.

Ah, I see. I'd not actually looked at the patch yet only the changelog
quoted in the discussion.

Attachment: signature.asc
Description: Digital signature