Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj()

[Tejun Heo]

Hello, Jason.

On Tue, Jun 23, 2015 at 10:19:32AM -0600, Jason Gunthorpe wrote:
> The concept was to move the sysfs files to the natural location on the
> core's struct tpm.struct device and leave a symlink behind on the
> platform_device for compat.

I see.  The only problem I see is that this might get abused.  Can you
clearly mark the function that it's not intended to be used in
anything new, e.g. by renaming it to sth like
__compat_only_sysfs_link_entry_to_kobj().

> We could also just move the sysfs file and ignore the compat symlink,
> but it is not clear to me if that is an OK UAPI break for sysfs?

We shouldn't if it has actual chance of disturbing userland.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/