Re: [PATCH 25/41] clocksource: tegra20: Migrate to new 'set-state' interface

[Daniel Lezcano]

On 06/18/2015 12:54 PM, Viresh Kumar wrote:
> Migrate tegra20 driver to the new 'set-state' interface provided by
> clockevents core, the earlier 'set-mode' interface is marked obsolete
> now.
>
> This also enables us to implement callbacks for new states of clockevent
> devices, for example: ONESHOT_STOPPED.
>
> Cc: Thierry Reding <treding@xxxxxxxxxx>
> Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---

[ ... ]

> +static int tegra_timer_shutdown(struct clock_event_device *evt)
>   {
> -	u32 reg;
> -
>   	timer_writel(0, TIMER3_BASE + TIMER_PTV);
> +	return 0;
> +}
>
> -	switch (mode) {
> -	case CLOCK_EVT_MODE_PERIODIC:
> -		reg = 0xC0000000 | ((1000000/HZ)-1);
> -		timer_writel(reg, TIMER3_BASE + TIMER_PTV);
> -		break;
> -	case CLOCK_EVT_MODE_ONESHOT:
> -		break;
> -	case CLOCK_EVT_MODE_UNUSED:
> -	case CLOCK_EVT_MODE_SHUTDOWN:
> -	case CLOCK_EVT_MODE_RESUME:
> -		break;
> -	}
> +static int tegra_timer_set_periodic(struct clock_event_device *evt)
> +{
> +	u32 reg = 0xC0000000 | ((1000000 / HZ) - 1);
> +
> +	timer_writel(0, TIMER3_BASE + TIMER_PTV);

Replace with 'tegra_timer_shutdown'

> +	timer_writel(reg, TIMER3_BASE + TIMER_PTV);
> +	return 0;
>   }



--
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/