Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq()

From: Peter Zijlstra
Date: Fri Jul 03 2015 - 12:10:58 EST


On Fri, Jul 03, 2015 at 09:09:12AM -0700, Cong Wang wrote:
> On Wed, Jun 24, 2015 at 12:41 PM, Cong Wang <xiyou.wangcong@xxxxxxxxx> wrote:
> > According to the comments, we need to test if this is
> > the first throttled task, however, list_empty() tests on
> > the entry cfs_rq->throttled_list, not the head, this is wrong.
> >
> > This is a bug because we don't re-init the list entry after
> > removing it from the list, so list_empty() could return false
> > even if the list is really empty.
> >
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Signed-off-by: Cong Wang <xiyou.wangcong@xxxxxxxxx>
> > Signed-off-by: Cong Wang <cwang@xxxxxxxxxxxxxxxx>
>
> ping.
>
> What's the status of this patch?

Queued, will likely hit tip after the merge window etc has settled.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/