Re: [PATCH 36/51] writeback: implement bdi_for_each_wb()

From: Tejun Heo
Date: Fri Jul 03 2015 - 13:07:02 EST


On Fri, Jul 03, 2015 at 02:26:27PM +0200, Jan Kara wrote:
> That's a good point. Thanks for explanation. Maybe add a comment like:
> /*
> * We use use this seemingly complicated 'for' loop so that 'break' and
> * 'continue' continue to work as expected.
> */

This kinda feel superflous for me. This is something true for all
iteration wrappers which falls within the area of well-established
convention, I think. If it's doing something weird like combining
if-else clause to do post-conditional processing, sure, but this is
really kinda standard.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/