Re: [PATCH 1/2] kconfig: also warn of unhandled characters in statements

From: Ulf Magnusson
Date: Sun Jul 05 2015 - 04:42:14 EST


On Sat, Jul 4, 2015 at 11:33 AM, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> On vr, 2015-07-03 at 14:46 +0200, Andreas Ruprecht wrote:
>> While commit 2e0d737fc76f ("kconfig: don't silently ignore unhandled
>> characters") introduced a warning for unsupported characters inside
>> parameters,
>
> What are "parameters"? The term doesn't show up in Documentation/kbuild.
>

zconf.l parses each line like "<COMMAND> <PARAM> <PARAM> ...", with a slightly
different set of characters allowed for <COMMAND> and <PARAM> (for whatever
reason). I agree that that's not clear from the commit message alone though.

(As a side note, that Flex/gperf split seems kinda odd to me. Does anyone know
of a good reason why more lexing wasn't done in zconf.l? Is it an optimization
attempt?)

Cheers,
Ulf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/