Re: [PATCH] thermal: exynos: Disable the regulator on probe failure

[Krzysztof Kozlowski]

2015-06-09 1:14 GMT+09:00 Lukasz Majewski <l.majewski@xxxxxxxxxxx>:
> Hi Krzysztof,
>
>> During probe the regulator (if present) was enabled but not disabled
>> in case of failure. So an unsuccessful probe lead to enabling the
>> regulator which was actually not needed because the device was not
>> enabled.
>>
>> Additionally each deferred probe lead to increase of regulator enable
>> count so it would not be effectively disabled during removal of the
>> device.
>
> Thanks for catching this.
>
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>> Fixes: 498d22f616f6 ("thermal: exynos: Support for TMU regulator
>> defined at device tree") Cc: <stable@xxxxxxxxxxxxxxx>
>>
>> ---
>>
>> I am not entirely convinced that this should go to stable. Leaving a
>> regulator enabled in case of probe failure (no exynos TMU device) or
>> after deferred probe (regulator won't be disabled during device
>> removal) is not a critical issue, just leaks power.
>> ---
>>  drivers/thermal/samsung/exynos_tmu.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/thermal/samsung/exynos_tmu.c
>> b/drivers/thermal/samsung/exynos_tmu.c index
>> 531f4b179871..13c3aceed19d 100644 ---
>> a/drivers/thermal/samsung/exynos_tmu.c +++
>> b/drivers/thermal/samsung/exynos_tmu.c @@ -1392,6 +1392,8 @@
>> err_clk_sec: if (!IS_ERR(data->clk_sec))
>>               clk_unprepare(data->clk_sec);
>>  err_sensor:
>> +     if (!IS_ERR_OR_NULL(data->regulator))
>> +             regulator_disable(data->regulator);
>>       thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd);
>>
>>       return ret;
>
> Acked-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
>
> I will test it and afterwards add to samsung-thermal tree.

Hi Åukasz,

I can't find this patch in v4.2-rc1 or your tree. What happened?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/