Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled

From: Felipe Balbi
Date: Mon Jul 06 2015 - 15:36:30 EST


On Mon, Jul 06, 2015 at 12:32:56PM -0700, Doug Anderson wrote:
> Felipe,
>
> On Mon, Jul 6, 2015 at 11:34 AM, Felipe Balbi <balbi@xxxxxx> wrote:
> > Hi,
> >
> > On Mon, Jul 06, 2015 at 11:27:04AM -0700, Douglas Anderson wrote:
> >> @@ -282,6 +296,28 @@ static int dwc2_driver_probe(struct platform_device *dev)
> >> return retval;
> >> }
> >>
> >> +static bool __maybe_unused dwc2_can_poweroff_phy(struct dwc2_hsotg *dwc2)
> >> +{
> >> + struct usb_device *root_hub = dwc2_hsotg_to_hcd(dwc2)->self.root_hub;
> >
> > what happens on peripheral only builds ?
>
> The function is only called on if "dwc2_is_device_mode(dwc2)" returns
> false. I think that means we're safe, right?

heh, missed that. Should be safe, yeah.

--
balbi

Attachment: signature.asc
Description: Digital signature