Re: [PATCH] clk: at91: Silence warnings and cleanup __init usage
From: Alexandre Belloni
Date: Mon Jul 06 2015 - 16:38:25 EST
Hi,
On 06/07/2015 at 12:31:45 -0700, Stephen Boyd wrote :
> Remove useless ifdefs around function prototypes to silence the
> following sparse warnings when the configs aren't enabled.
>
> drivers/clk/at91/clk-h32mx.c:95:13: warning: symbol
> 'of_sama5d4_clk_h32mx_setup' was not declared. Should it be
> static?
> drivers/clk/at91/clk-utmi.c:159:13: warning: symbol
> 'of_at91sam9x5_clk_utmi_setup' was not declared. Should it be
> static?
>
> Plus, using __init in function prototypes doesn't do anything, so
> just drop it throughout this file.
>
The main drawback of that removal is that it destroys the alignment
throughout the header file :)
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/