Re: [PATCH] mfd: qcom-rpm: Add apq8064 QDSS clock resource

[Ivan T. Ivanov]

On Mon, 2015-07-06 at 13:33 -0700, Bjorn Andersson wrote:
> On Mon 18 May 07:35 PDT 2015, Ivan T. Ivanov wrote:
> 
> > Qualcomm Debug Subsystem clock is used by CoreSight components.
> > Add required definitions for it.
> > 
> > Signed-off-by: Ivan T. Ivanov ivanov@xxxxxxxxxx>
> 
> Sorry for the slow response Ivan.
> 
> > ---
> >  drivers/mfd/qcom_rpm.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> > index eceb34f..313aeae 100644
> > --- a/drivers/mfd/qcom_rpm.c
> > +++ b/drivers/mfd/qcom_rpm.c
> > @@ -149,6 +149,7 @@ static const struct qcom_rpm_resource apq8064_rpm_resource_table[] = {
> >         [QCOM_RPM_USB_OTG_SWITCH] ={ 210, 125, 82, 1 },
> >         [QCOM_RPM_HDMI_SWITCH] ={ 211, 126, 83, 1 },
> >         [QCOM_RPM_DDR_DMM] ={ 212, 127, 84, 2 },
> > +       [QCOM_RPM_QDSS_CLK] ={ 214, 129, 7, 1 },
> 
> 214, 7 and 1 are correct. But as far as I can see in my tables the QDSS
> clock doesn't have any status (129 seems to be EBI1_CH0_RANGE).
> 
> The status_id was originally included because I was reading it and I saw
> that Srinivas has some code that reads it, but unless it shows to be
> useful we should probably just drop that entire column...
> 
> But for now please mark it as -1 or so and we can have a chat with
> Srinivas on dropping the column later.

Thanks, I was unsure about this. This is just what I have found 
digging into codeaurora sources. Will change and resubmit.

Ivan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/