RE: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature

[Dexuan Cui]

> -----Original Message-----
> From: Olaf Hering [mailto:olaf@xxxxxxxxx]
> Sent: Tuesday, July 7, 2015 18:10
> To: Dexuan Cui; Paul Bolle
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev-
> devel@xxxxxxxxxxxxxxxxxxxxxx; apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; KY
> Srinivasan; Haiyang Zhang
> Subject: Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
> 
> On Tue, Jul 07, Paul Bolle wrote:
> 
> > On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote:
> > > --- /dev/null
> > > +++ b/net/hv_sock/Kconfig
> >
> > > +config HYPERV_SOCK
> > > +	tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)"
> > > +	depends on HYPERV
> > > +	default m
> 
> > It's a bit odd to advise to say N if one is unsure and set the default
> > to 'm' at the same time.
> 
> The 'default' line has to be removed IMO.
> 
> Olaf

OK, removing the line seems better than 'default n', though both reproduce
the same "# CONFIG_HYPERV_SOCK is not set".

-- Dexuan