Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

From: Jiri Kosina
Date: Tue Jul 07 2015 - 16:49:59 EST


On Tue, 7 Jul 2015, Gabriele Mazzotta wrote:

> The irq is most likely required by the suspend callback, so disable it
> only after the callback had been executed.

It would be nice to have a more verbose changelog here -- i.e. why we want
to do such change and what could go wrong if IRQ is disabled too early
(i.e. what bug is this exactly fixing).

>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@xxxxxxxxx>

I'd see this as a 4.2 material still. Please let me know if you'd rather
want to wait for 4.3.

Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/