Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

From: Masahiro Yamada
Date: Wed Jul 08 2015 - 01:02:38 EST

Next message: Vaishali Thakkar: "[PATCH] net: systemport: Use eth_hw_addr_random"
Previous message: Vaishali Thakkar: "[PATCH] uio: uio_fsl_elbc_gpcm: Use module_platform_driver"
Next in thread: Paul Bolle: "Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Paul,

2015-07-07 18:14 GMT+09:00 Paul Bolle <pebolle@xxxxxxxxxx>:
> (I only comment on 1/7, because it's not useful to repeat one remark
> seven times.)
>
> On ma, 2015-07-06 at 21:29 +0900, Masahiro Yamada wrote:
>> --- /dev/null
>> +++ b/drivers/pinctrl/uniphier/Kconfig
>
>> +config PINCTRL_UNIPHIER_CORE
>> + bool
>> + select PINMUX
>> + select GENERIC_PINCONF
>
>> --- /dev/null
>> +++ b/drivers/pinctrl/uniphier/Makefile
>
>> +obj-$(CONFIG_PINCTRL_UNIPHIER_CORE) += pinctrl-uniphier-core.o
>
>> --- /dev/null
>> +++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-core.c
>
>> +#include <linux/module.h>
>
>> +int uniphier_pinctrl_probe(struct platform_device *pdev,
>> + struct pinctrl_desc *desc,
>> + struct uniphier_pinctrl_socdata *socdata)
>> +{
>> + [...]
>
>> + desc->owner = THIS_MODULE;
>
>> + [...]
>> +}
>
> This series adds a number of bool Kconfig symbols. So, as far as I can
> see, the code it adds can only be built-in.
>
> This series also uses a number of module specific constructs (ie,
> THIS_MODULE, MODULE_DEVICE_TABLE, module_exit, MODULE_AUTHOR,
> MODULE_DESCRIPTION, and MODULE_LICENSE). So I wonder whether it was
> intended to make these new Kconfig symbols tristate instead?
>

I think it could be tristate if
- all the "pinctrl-names" properties are ripped off from the
mandatory devices in the device tree
- all the necessary pinmux settings have been done in the
boot-loader or somewhere.

But, such a use-case is really limited, so either boolean or tristate
makes sense for pinctrl drivers, I think.

Actually, most of pinctrl drivers are boolean, but most of them
conventionally have MODULE_AUTHOR, THIS_MODULE, etc.

I do not think it looks so weird. Thought?

$ git grep MODULE_AUTHOR -- drivers/pinctrl/

drivers/pinctrl/bcm/pinctrl-bcm281xx.c:MODULE_AUTHOR("Broadcom
Corporation <bcm-kernel-feedback-list@xxxxxxxxxxxx>");
drivers/pinctrl/bcm/pinctrl-bcm281xx.c:MODULE_AUTHOR("Sherman Yin
<syin@xxxxxxxxxxxx>");
drivers/pinctrl/bcm/pinctrl-bcm2835.c:MODULE_AUTHOR("Chris Boot, Simon
Arlott, Stephen Warren");
drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:MODULE_AUTHOR("Ray Jui
<rjui@xxxxxxxxxxxx>");
drivers/pinctrl/berlin/berlin-bg2.c:MODULE_AUTHOR("Antoine TÃÂnart
<antoine.tenart@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/berlin/berlin-bg2cd.c:MODULE_AUTHOR("Antoine TÃÂnart
<antoine.tenart@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/berlin/berlin-bg2q.c:MODULE_AUTHOR("Antoine TÃÂnart
<antoine.tenart@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx1.c:MODULE_AUTHOR("Alexander
Shiyan <shc_work@xxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx21.c:MODULE_AUTHOR("Alexander
Shiyan <shc_work@xxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx23.c:MODULE_AUTHOR("Shawn Guo
<shawn.guo@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx25.c:MODULE_AUTHOR("Denis Carikli
<denis@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx27.c:MODULE_AUTHOR("Markus
Pargmann <mpa@xxxxxxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx28.c:MODULE_AUTHOR("Shawn Guo
<shawn.guo@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx35.c:MODULE_AUTHOR("Dong Aisheng
<dong.aisheng@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx51.c:MODULE_AUTHOR("Dong Aisheng
<dong.aisheng@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx53.c:MODULE_AUTHOR("Dong Aisheng
<dong.aisheng@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx6dl.c:MODULE_AUTHOR("Shawn Guo
<shawn.guo@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx6q.c:MODULE_AUTHOR("Dong Aisheng
<dong.aisheng@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx6sl.c:MODULE_AUTHOR("Shawn Guo
<shawn.guo@xxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx6sx.c:MODULE_AUTHOR("Anson Huang
<Anson.Huang@xxxxxxxxxxxxx>");
drivers/pinctrl/freescale/pinctrl-imx7d.c:MODULE_AUTHOR("Anson Huang
<Anson.Huang@xxxxxxxxxxxxx>");
drivers/pinctrl/intel/pinctrl-cherryview.c:MODULE_AUTHOR("Mika
Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>");
drivers/pinctrl/intel/pinctrl-intel.c:MODULE_AUTHOR("Mathias Nyman
<mathias.nyman@xxxxxxxxxxxxxxx>");
drivers/pinctrl/intel/pinctrl-intel.c:MODULE_AUTHOR("Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx>");
drivers/pinctrl/intel/pinctrl-sunrisepoint.c:MODULE_AUTHOR("Mathias
Nyman <mathias.nyman@xxxxxxxxxxxxxxx>");
drivers/pinctrl/intel/pinctrl-sunrisepoint.c:MODULE_AUTHOR("Mika
Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>");
drivers/pinctrl/mediatek/pinctrl-mt6397.c:MODULE_AUTHOR("Hongzhou Yang
<hongzhou.yang@xxxxxxxxxxxx>");
drivers/pinctrl/mediatek/pinctrl-mt8127.c:MODULE_AUTHOR("Yingjoe Chen
<yingjoe.chen@xxxxxxxxxxxx>");
drivers/pinctrl/mediatek/pinctrl-mt8135.c:MODULE_AUTHOR("Hongzhou Yang
<hongzhou.yang@xxxxxxxxxxxx>");
drivers/pinctrl/mediatek/pinctrl-mt8173.c:MODULE_AUTHOR("Hongzhou Yang
<hongzhou.yang@xxxxxxxxxxxx>");
drivers/pinctrl/mediatek/pinctrl-mtk-common.c:MODULE_AUTHOR("Hongzhou
Yang <hongzhou.yang@xxxxxxxxxxxx>");
drivers/pinctrl/meson/pinctrl-meson.c:MODULE_AUTHOR("Beniamino Galvani
<b.galvani@xxxxxxxxx>");
drivers/pinctrl/mvebu/pinctrl-armada-370.c:MODULE_AUTHOR("Thomas
Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/mvebu/pinctrl-armada-375.c:MODULE_AUTHOR("Thomas
Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/mvebu/pinctrl-armada-38x.c:MODULE_AUTHOR("Thomas
Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/mvebu/pinctrl-armada-39x.c:MODULE_AUTHOR("Thomas
Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/mvebu/pinctrl-armada-xp.c:MODULE_AUTHOR("Thomas
Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/mvebu/pinctrl-dove.c:MODULE_AUTHOR("Sebastian
Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>");
drivers/pinctrl/mvebu/pinctrl-kirkwood.c:MODULE_AUTHOR("Sebastian
Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>");
drivers/pinctrl/mvebu/pinctrl-orion.c:MODULE_AUTHOR("Thomas Petazzoni
<thomas.petazzoni@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/nomadik/pinctrl-abx500.c:MODULE_AUTHOR("Patrice
Chotard <patrice.chotard@xxxxxx>");
drivers/pinctrl/nomadik/pinctrl-nomadik.c:MODULE_AUTHOR("Prafulla
WADASKAR and Alessandro Rubini");
drivers/pinctrl/pinctrl-adi2.c:MODULE_AUTHOR("Sonic Zhang
<sonic.zhang@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-amd.c:MODULE_AUTHOR("Ken Xue
<Ken.Xue@xxxxxxx>, Jeff Wu <Jeff.Wu@xxxxxxx>");
drivers/pinctrl/pinctrl-as3722.c:MODULE_AUTHOR("Laxman
Dewangan<ldewangan@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-at91.c:MODULE_AUTHOR("Jean-Christophe
PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>");
drivers/pinctrl/pinctrl-coh901.c:MODULE_AUTHOR("Linus Walleij
<linus.walleij@xxxxxxxxxxxxxx>");
drivers/pinctrl/pinctrl-lpc18xx.c:MODULE_AUTHOR("Joachim Eastwood
<manabian@xxxxxxxxx>");
drivers/pinctrl/pinctrl-palmas.c:MODULE_AUTHOR("Laxman
Dewangan<ldewangan@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-rockchip.c:MODULE_AUTHOR("Heiko Stuebner
<heiko@xxxxxxxxx>");
drivers/pinctrl/pinctrl-single.c:MODULE_AUTHOR("Tony Lindgren
<tony@xxxxxxxxxxx>");
drivers/pinctrl/pinctrl-tb10x.c:MODULE_AUTHOR("Christian Ruppert
<christian.ruppert@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-tegra-xusb.c:MODULE_AUTHOR("Thierry Reding
<treding@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-tegra114.c:MODULE_AUTHOR("Pritesh Raithatha
<praithatha@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-tegra124.c:MODULE_AUTHOR("Ashwini Ghuge
<aghuge@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-tegra20.c:MODULE_AUTHOR("Stephen Warren
<swarren@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-tegra210.c:MODULE_AUTHOR("NVIDIA");
drivers/pinctrl/pinctrl-tegra30.c:MODULE_AUTHOR("Stephen Warren
<swarren@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-tz1090-pdc.c:MODULE_AUTHOR("Imagination
Technologies Ltd.");
drivers/pinctrl/pinctrl-tz1090.c:MODULE_AUTHOR("Imagination Technologies Ltd.");
drivers/pinctrl/pinctrl-u300.c:MODULE_AUTHOR("Linus Walleij
<linus.walleij@xxxxxxxxxx>");
drivers/pinctrl/pinctrl-zynq.c:MODULE_AUTHOR("SÃÂren Brinkmann
<soren.brinkmann@xxxxxxxxxx>");
drivers/pinctrl/qcom/pinctrl-apq8064.c:MODULE_AUTHOR("Bjorn Andersson
<bjorn.andersson@xxxxxxxxxxxxxx>");
drivers/pinctrl/qcom/pinctrl-ipq8064.c:MODULE_AUTHOR("Andy Gross
<agross@xxxxxxxxxxxxxx>");
drivers/pinctrl/qcom/pinctrl-msm8660.c:MODULE_AUTHOR("Bjorn Andersson
<bjorn.andersson@xxxxxxxxxxxxxx>");
drivers/pinctrl/qcom/pinctrl-msm8960.c:MODULE_AUTHOR("Bjorn Andersson
<bjorn.andersson@xxxxxxxxxxxxxx>");
drivers/pinctrl/qcom/pinctrl-msm8x74.c:MODULE_AUTHOR("Bjorn Andersson
<bjorn.andersson@xxxxxxxxxxxxxx>");
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:MODULE_AUTHOR("Ivan T. Ivanov
<iivanov@xxxxxxxxxx>");
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c:MODULE_AUTHOR("Ivan T. Ivanov
<iivanov@xxxxxxxxxx>");
drivers/pinctrl/samsung/pinctrl-exynos5440.c:MODULE_AUTHOR("Thomas
Abraham <thomas.ab@xxxxxxxxxxx>");
drivers/pinctrl/samsung/pinctrl-samsung.c:MODULE_AUTHOR("Thomas
Abraham <thomas.ab@xxxxxxxxxxx>");
drivers/pinctrl/sh-pfc/core.c:MODULE_AUTHOR("Magnus Damm, Paul Mundt,
Laurent Pinchart");
drivers/pinctrl/sirf/pinctrl-sirf.c:MODULE_AUTHOR("Rongjun Ying
<rongjun.ying@xxxxxxx>");
drivers/pinctrl/sirf/pinctrl-sirf.c:MODULE_AUTHOR("Yuping Luo
<yuping.luo@xxxxxxx>");
drivers/pinctrl/sirf/pinctrl-sirf.c:MODULE_AUTHOR("Barry Song
<baohua.song@xxxxxxx>");
drivers/pinctrl/spear/pinctrl-plgpio.c:MODULE_AUTHOR("Viresh Kumar
<viresh.kumar@xxxxxxxxxx>");
drivers/pinctrl/spear/pinctrl-spear1310.c:MODULE_AUTHOR("Viresh Kumar
<viresh.linux@xxxxxxxxx>");
drivers/pinctrl/spear/pinctrl-spear1340.c:MODULE_AUTHOR("Viresh Kumar
<viresh.linux@xxxxxxxxx>");
drivers/pinctrl/spear/pinctrl-spear300.c:MODULE_AUTHOR("Viresh Kumar
<viresh.linux@xxxxxxxxx>");
drivers/pinctrl/spear/pinctrl-spear310.c:MODULE_AUTHOR("Viresh Kumar
<viresh.linux@xxxxxxxxx>");
drivers/pinctrl/spear/pinctrl-spear320.c:MODULE_AUTHOR("Viresh Kumar
<viresh.linux@xxxxxxxxx>");
drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c:MODULE_AUTHOR("Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun5i-a10s.c:MODULE_AUTHOR("Maxime
Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun5i-a13.c:MODULE_AUTHOR("Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c:MODULE_AUTHOR("Boris
Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c:MODULE_AUTHOR("Maxime
Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c:MODULE_AUTHOR("Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun6i-a31s.c:MODULE_AUTHOR("Hans de
Goede <hdegoede@xxxxxxxxxx>");
drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c:MODULE_AUTHOR("Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c:MODULE_AUTHOR("Chen-Yu
Tsai <wens@xxxxxxxx>");
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c:MODULE_AUTHOR("Boris
Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c:MODULE_AUTHOR("Maxime
Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c:MODULE_AUTHOR("Chen-Yu Tsai
<wens@xxxxxxxx>");
drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c:MODULE_AUTHOR("Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx");
drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c:MODULE_AUTHOR("Vishnu
Patekar <vishnupatekar0510@xxxxxxxxx>");
drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c:MODULE_AUTHOR("Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx>");
drivers/pinctrl/vt8500/pinctrl-vt8500.c:MODULE_AUTHOR("Tony Prisk
<linux@xxxxxxxxxxxxxxx>");
drivers/pinctrl/vt8500/pinctrl-wm8505.c:MODULE_AUTHOR("Tony Prisk
<linux@xxxxxxxxxxxxxxx>");
drivers/pinctrl/vt8500/pinctrl-wm8650.c:MODULE_AUTHOR("Tony Prisk
<linux@xxxxxxxxxxxxxxx>");
drivers/pinctrl/vt8500/pinctrl-wm8750.c:MODULE_AUTHOR("Tony Prisk
<linux@xxxxxxxxxxxxxxx>");
drivers/pinctrl/vt8500/pinctrl-wm8850.c:MODULE_AUTHOR("Tony Prisk
<linux@xxxxxxxxxxxxxxx>");

--
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Vaishali Thakkar: "[PATCH] net: systemport: Use eth_hw_addr_random"
Previous message: Vaishali Thakkar: "[PATCH] uio: uio_fsl_elbc_gpcm: Use module_platform_driver"
Next in thread: Paul Bolle: "Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]