Re: [PATCH 1/2] net: can: c_can: Fix default pinmux glitch at init

[Roger Quadros]

Marc,

On 07/07/15 17:43, Marc Kleine-Budde wrote:
> On 07/07/2015 04:37 PM, Roger Quadros wrote:
> > > > > diff --git a/drivers/net/can/c_can/c_can.c
> > > > > b/drivers/net/can/c_can/c_can.c
> > > > > index 041525d..66e98e7 100644
> > > > > --- a/drivers/net/can/c_can/c_can.c
> > > > > +++ b/drivers/net/can/c_can/c_can.c
> > > > > @@ -605,7 +605,18 @@ static int c_can_start(struct net_device *dev)
> > > > >        priv->can.state = CAN_STATE_ERROR_ACTIVE;
> > > > >
> > > > >        /* activate pins */
> > > > > -    pinctrl_pm_select_default_state(dev->dev.parent);
> > > > > +#ifdef CONFIG_PINCTRL
> > > >
> > > > Please remove the ifdef, AFAICS there are static inline noop functions
> > > > if CONFIG_PINCTRL switched off.
> > >
> > > yes, you are right.
> >
> > On second thoughts
> >
> > device->pins are not defined if CONFIG_PINCTRL is not set.
> > so we can't remove the #ifdef.
>
> Too bad :(
>
> okay - should I add stable@xxxxx on Cc?

I'm not sure if it would help. This patch by itself won't fix anything. 
It needs to go in together with the DTS change in patch 2.

Maybe if Tony can Ack the second patch then both should be applicable
on v4.0+ for stable.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/