Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

[Alexander Shishkin]

Chunyan Zhang <zhang.lyra@xxxxxxxxx> writes:

>> +int __init stp_configfs_init(void)
>> +{
>> +       int err;
>> +
>> +       config_group_init(&stp_policy_subsys.su_group);
>> +       mutex_init(&stp_policy_subsys.su_mutex);
>> +       err = configfs_register_subsystem(&stp_policy_subsys);
>> +
>> +       return err;
>
> One small suggestion, is it better like this:
> return configfs_register_subsystem(&stp_policy_subsys);
> As such, we don't need the local variable "err" any more.

You are right, err doesn't serve any purpose here.

Thanks,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/