Re: config PROC_CHILDREN

From: Jean Delvare
Date: Wed Jul 08 2015 - 12:34:57 EST


Le Wednesday 08 July 2015 Ã 16:18 +0200, Iago LÃpez Galeiras a Ãcrit :
> On 07/04/2015 07:07 PM, Jean Delvare wrote:
> > On Fri, 3 Jul 2015 11:10:45 +0200, Iago LÃpez Galeiras wrote:
> >> The purpose of this option is enabling /proc/<pid>/task/<tid>/children without
> >> having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.
> >>
> >> Regarding its lack of help, documentation is in already in place[1] but perhaps
> >> that's not clear for the user because as you say the Kconfig help text is missing.
> >>
> >> I suggest adding something like:
> >>
> >> Provides a fast way to retrieve first level children pids of a task. See
> >> <file:Documentation/filesystems/proc.txt> for more information.
> >>
> >> Do you think that's enough?
> >
> > That's a start, the reference to Documentation/filesystems/proc.txt is
> > good but I think we can do better. You need to help the user make the
> > decision. Why should he/she say Y or N? The user should NOT have to look
> > at an external documentation file if the answer is N. I would suggest
> > the following:
> >
> > Say Y if running any user-space software which takes benefit from this
> > interface. For example, rkt is such a piece of software.
>
> That makes it more clear for the user. Thanks!

You're welcome. Will you submit a patch, or should I take care of it?

--
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/