On Mon, Jun 29, 2015 at 7:23 AM, Bamvor Zhang Jian
<bamvor.zhangjian@xxxxxxxxxx> wrote:
+int get_timeval64(struct timeval64 *tv,
+ const struct __kernel_timeval __user *utv)
+{
+ struct __kernel_timeval ktv;
+ int ret;
+
+ ret = copy_from_user(&ktv, utv, sizeof(ktv));
+ if (ret)
+ return -EFAULT;
+
+ tv->tv_sec = ktv.tv_sec;
+ if (!IS_ENABLED(CONFIG_64BIT)
+#ifdef CONFIG_COMPAT
+ || is_compat_task()
+#endif
These sorts of ifdefs are to be avoided inside of functions.
Instead, it seems is_compat_task() should be defined to 0 in theI add this ifdef because I got compile failure on arm platform. This
!CONFIG_COMPAT case, so you can avoid the ifdefs and the compiler can
still optimize it out.
Otherwise this looks similar to a patch Baolin (cc'ed) has been working on.Yes.
--
thanks
-john