Re: [PATCH v4.0 for testing] nbd: Fix timeout detection

[Markus Pargmann]

Hi Hermann,

On Thu, Jul 09, 2015 at 10:06:52AM +0200, Hermann Lauer wrote:
> Hello Markus,
> 
> > On Fri, Apr 24, 2015 at 09:35:33AM +0200, Markus Pargmann wrote:
> > > At the moment the nbd timeout just detects hanging tcp operations. This
> > > is not enough to detect a hanging or bad connection as expected of a
> > > timeout.
> > ...
> > > Cc: Michal Belczyk <belczyk@xxxxxxxxxxxxx>
> > > Cc: Hermann Lauer <Hermann.Lauer@xxxxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
> > > [mpa: Backported to 4.0]
> > > 
> > > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
> > > ---
> > > 
> > > This patch is only for testing at the moment. I will backport the final patch
> > > for the stable tree at the end.
> > 
> > tested with 4.0 - timeout works as expected after
> > disconnecting the ethernet.
> > No hang or unexpected kernel message.
> 
> still no problems so far - may I ask if the patch made his way upstream ?
> If you already submitted it, knowing the commit would be nice to tell
> it to the Debian maintainers.

Thanks for reporting. Sorry for the delay, but I queued the patch for
4.3 yesterday.

The patch will not go into the stable kernel trees. This is somehow more
of a feature than a bug. The timeout works as it was designed. This
patch just makes the timeout handling more intuitive for the user.

I hope this is fine for you.

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: Digital signature