Re: [PATCH v2] coresight: replicator: Use module_platform_driver

[Paul Bolle]

On vr, 2015-07-10 at 01:29 +0530, Vaishali Thakkar wrote:
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c

> -static int __init replicator_init(void)
> -{
> -	return platform_driver_register(&replicator_driver);
> -}
> -module_init(replicator_init);
> -
> -static void __exit replicator_exit(void)
> -{
> -	platform_driver_unregister(&replicator_driver);
> -}
> -module_exit(replicator_exit);
> +module_platform_driver(replicator_driver);

coresight-replicator.o is built if CONFIG_CORESIGHT_LINKS_AND_SINKS is
defined. CORESIGHT_LINKS_AND_SINKS is a bool symbol. It depends on
CORESIGHT, which is also a bool symbol. CORESIGHT is a top level symbol,
available on arm and arm64.

I think coresight-replicator.o can only be built-in. So I suggest to use
builtin_platform_driver() instead.

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/