Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

[David Miller]

From: Andrew Lunn <andrew@xxxxxxx>
Date: Wed, 8 Jul 2015 16:52:34 +0200

> On Tue, Jul 07, 2015 at 08:38:15PM -0700, Guenter Roeck wrote:
>> From: "Aleksey S. Kazantsev" <ioctl@xxxxxxxxx>
>> 
>> MV88E6320 and MV88E6321 are largely compatible to MV886352,
>> but are members of a different chip family.
>> 
>> Signed-off-by: Aleksey S. Kazantsev <ioctl@xxxxxxxxx>
>> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> 
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> 
> One thing we might want to consider, is moving the temperate sensor
> code into mv88e6xxx. It seems likely future devices will also have the
> same sensor, so moving it to the shared code would make sense. We can
> then keep all mv88e6xxx_XXXX_family() stuff in a single file.
> 
> I don't see this as a blocker for this patchset, but now might be the
> right time to do this.

Please do not quote an entire patch just to add a reviewed-by or
acked-by tag.   If you have to quote some of the patch to comment
on specific portions, only quote exactly the hunks of the patch
relevant to what you want to discuss.

It doesn't take much effort to properly clip all except the most
relevant quoted text in your reply, and doing so I consider a very
basic common courtesy to everyone else on this mailing list.  It's
especially a courtesy to me as I have to scroll through the threads
and patchwork entries for every single patch posted here.

Thanks in advance for your consideration.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/