Resend: Re: [PATCH] x86: MCA: garbage collect sys_desc_table

[Paolo Pisati]

On Wed, Jul 08, 2015 at 07:14:36PM +0200, Paolo Pisati wrote:

Adding Josh Triplett since he was interested in MCA removal for the kernel tinification project, and slightly change
the subject line.

> Is sys_desc_table still used anywhere? It seems not:
> 
> arch/x86/boot/mca.c::query_mca()
> ...
>     copy_from_fs(&boot_params.sys_desc_table, oreg.bx, len);
> ...
> 
> arch/x86/kernel/setup.c::setup_arch()
> ...
>     if (boot_params.sys_desc_table.length != 0) {
>         machine_id = boot_params.sys_desc_table.table[0];
>         machine_submodel_id = boot_params.sys_desc_table.table[1];
>         BIOS_revision = boot_params.sys_desc_table.table[2];
>     }
> ...
> 
> $ git grep machine_id
> ...
> arch/x86/include/asm/processor.h:extern unsigned int            machine_id;
> arch/x86/kernel/setup.c:unsigned int machine_id;
> arch/x86/kernel/setup.c:                machine_id = boot_params.sys_desc_table.table[0];
> ...
> 
> $ git grep machine_submodel_id
> arch/x86/include/asm/processor.h:extern unsigned int machine_submodel_id;
> arch/x86/kernel/setup.c:unsigned int machine_submodel_id;
> arch/x86/kernel/setup.c:                machine_submodel_id = boot_params.sys_desc_table.table[1];
> 
> $ git grep BIOS_revision
> arch/x86/include/asm/processor.h:extern unsigned int            BIOS_revision;
> arch/x86/kernel/setup.c:unsigned int BIOS_revision;
> arch/x86/kernel/setup.c:                BIOS_revision = boot_params.sys_desc_table.table[2];
> 
> Compile tested with i386_defconfig, x86_64_defconfig and allyesconfig.
> 
> Paolo Pisati (1):
>   MCA: garbage collect sys_desc_table
> 
>  Documentation/x86/zero-page.txt       |  1 -
>  arch/x86/boot/Makefile                |  2 +-
>  arch/x86/boot/boot.h                  |  3 ---
>  arch/x86/boot/compressed/eboot.c      |  4 ----
>  arch/x86/boot/main.c                  |  3 ---
>  arch/x86/boot/mca.c                   | 38 -----------------------------------
>  arch/x86/include/asm/processor.h      |  8 --------
>  arch/x86/include/uapi/asm/bootparam.h | 19 +++++++-----------
>  arch/x86/kernel/kexec-bzimage64.c     |  3 ---
>  arch/x86/kernel/setup.c               |  5 -----
>  10 files changed, 8 insertions(+), 78 deletions(-)
>  delete mode 100644 arch/x86/boot/mca.c
> 
> -- 
> 2.1.4
> 

-- 
bye,
p.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/