RE: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver

From: Rama Kiran Kumar Indrakanti
Date: Fri Jul 10 2015 - 05:12:53 EST


<br><br>&gt; From: k.kozlowski@xxxxxxxxxxx<br>&gt; To: gregkh@xxxxxxxxxxxxxxxxxxx; jslaby@xxxxxxx; ralf@xxxxxxxxxxxxxx; k.kozlowski@xxxxxxxxxxx; paul.burton@xxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx<br>&gt; Subject: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver<br>&gt; Date: Fri, 10 Jul 2015 15:36:20 +0900<br>&gt; <br>&gt; i2c_driver does not need to set an owner because i2c_register_driver()<br>&gt; will set it.<br>&gt; <br>&gt; Signed-off-by: Krzysztof Kozlowski &lt;k.kozlowski@xxxxxxxxxxx&gt;<br>&gt; <br>&gt; ---<br>&gt; <br>&gt; The coccinelle script which generated the patch was sent here:<br>&gt; http://www.spinics.net/lists/kernel/msg2029903.html<br>&gt; ---<br>&gt; drivers/tty/serial/sc16is7xx.c | 1 -<br>&gt; 1 file changed, 1 deletion(-)<br>&gt; <br>&gt; diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c<br>&gt; index 9e6576004a42..bbeb33561737 100644<br>&gt; --- a/drivers/tty/serial/sc16is7xx.c<br>&gt; +++ b/drivers/tty/serial/sc16is7xx.c<br>&gt; @@ -1369,7 +1369,6 @@ MODULE_DEVICE_TABLE(i2c, sc16is7xx_i2c_id_table);<br>&gt; static struct i2c_driver sc16is7xx_i2c_uart_driver = {<br>&gt; .driver = {<br>&gt; .name = SC16IS7XX_NAME,<br>&gt; - .owner = THIS_MODULE,<br><br>Okay, is there an issue by doing this. Or its just a over doing things ?<br><br>&gt; .of_match_table = of_match_ptr(sc16is7xx_dt_ids),<br>&gt; },<br>&gt; .probe = sc16is7xx_i2c_probe,<br>&gt; -- <br>&gt; 1.9.1<br>&gt; <br>&gt; --<br>&gt; To unsubscribe from this list: send the line "unsubscribe linux-serial" in<br>&gt; the body of a message to majordomo@xxxxxxxxxxxxxxx<br>&gt; More majordomo info at http://vger.kernel.org/majordomo-info.html<br> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/