RE: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver
From: Rama Kiran Kumar Indrakanti
Date: Fri Jul 10 2015 - 05:12:53 EST
<br><br>> From: k.kozlowski@xxxxxxxxxxx<br>> To: gregkh@xxxxxxxxxxxxxxxxxxx; jslaby@xxxxxxx; ralf@xxxxxxxxxxxxxx; k.kozlowski@xxxxxxxxxxx; paul.burton@xxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx<br>> Subject: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver<br>> Date: Fri, 10 Jul 2015 15:36:20 +0900<br>> <br>> i2c_driver does not need to set an owner because i2c_register_driver()<br>> will set it.<br>> <br>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx><br>> <br>> ---<br>> <br>> The coccinelle script which generated the patch was sent here:<br>> http://www.spinics.net/lists/kernel/msg2029903.html<br>> ---<br>> drivers/tty/serial/sc16is7xx.c | 1 -<br>> 1 file changed, 1 deletion(-)<br>> <br>> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c<br>> index 9e6576004a42..bbeb33561737 100644<br>> --- a/drivers/tty/serial/sc16is7xx.c<br>> +++ b/drivers/tty/serial/sc16is7xx.c<br>> @@ -1369,7 +1369,6 @@ MODULE_DEVICE_TABLE(i2c, sc16is7xx_i2c_id_table);<br>> static struct i2c_driver sc16is7xx_i2c_uart_driver = {<br>> .driver = {<br>> .name = SC16IS7XX_NAME,<br>> - .owner = THIS_MODULE,<br><br>Okay, is there an issue by doing this. Or its just a over doing things ?<br><br>> .of_match_table = of_match_ptr(sc16is7xx_dt_ids),<br>> },<br>> .probe = sc16is7xx_i2c_probe,<br>> -- <br>> 1.9.1<br>> <br>> --<br>> To unsubscribe from this list: send the line "unsubscribe linux-serial" in<br>> the body of a message to majordomo@xxxxxxxxxxxxxxx<br>> More majordomo info at http://vger.kernel.org/majordomo-info.html<br> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/