Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status

From: Vaibhav Hiremath
Date: Fri Jul 10 2015 - 08:11:28 EST




On Friday 10 July 2015 12:35 AM, Mark Brown wrote:
On Thu, Jul 09, 2015 at 06:11:32PM +0530, Vaibhav Hiremath wrote:
This patch adds dev_info line at the end of probe function, to
clearly put status of regulator probe on console. Useful during
development, specially to check bootlog.

+ dev_info(&pdev->dev, "Regulator registered ...\n");
return 0;

No, this is pure noise - all you're doing is slowing down boot for users
with no content. Think about what would happen if every driver did
this. The core already displays the constraints when things are
registered.



I was just trying my luck here :)

And honestly, this was useful for me atleast.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/