Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

From: Scott Wood
Date: Fri Jul 10 2015 - 13:33:37 EST


On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote:
> On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
> > +#ifdef CONFIG_FSL_DPA_CHECKING
> > +#define DPA_ASSERT(x) \
> > + do { \
> > + if (!(x)) { \
> > + pr_crit("ASSERT: (%s:%d) %s\n", __FILE__, __LINE__, \
> > + __stringify_1(x)); \
> > + dump_stack(); \
> > + panic("assertion failure"); \
>
> Not my call, but why panic() here?

I'm pretty sure I've complained about this before (as well as all the
BUG_ONs).

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/