RE: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

[Roy Pledge]

>   return in_be32((void *)bm + offset);
> >          ^
> > [...]/drivers/soc/fsl/qbman/bman.c: In function â__bm_outâ:
> > [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration
> > of function âout_be32â [-Werror=implicit-function-declaration]
> >   out_be32((void *)bm + offset, val);
> 
> These PPCisms will need to be fixed.  LS1043A is an ARM chip with DPAA 1.0.

LS1043 (ARM, Little Endian) support is still work in progress.  The patches for that are being tested now but are based on the SDK version of the driver and will need to be massaged in order to get them applied here.  Our plan of record is to add upstream support for this at a later time.

> 
> >   ^
> > [...]/drivers/soc/fsl/qbman/bman.c: In function âof_fsl_bman_probeâ:
> > [...]/drivers/soc/fsl/qbman/bman.c:463:17: error: âNO_IRQâ undeclared
> > (first use in this function)
> >   if (err_irq == NO_IRQ) {
> 
> This isn't even a PPCism.  It's just wrong.  Compare to zero instead.

Yeah - I recall fixing this when doing the ARM port but I guess I didn't make the same change in this version.  I will address this in the next version.


> 
> -Scott