Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

[Chris Metcalf]

On 7/10/2015 6:45 PM, Josh Cartwright wrote:
> > +static inline const struct cpumask *housekeeping_cpumask(void)
> > >+{
> > >+#ifdef CONFIG_NO_HZ_FULL
> > >+	if (tick_nohz_full_enabled())
> > >+		return housekeeping_mask;
> > >+#endif
> Just a small comment:
>
> We can take these checks out from under a #ifdef CONFIG_NO_HZ_FULL
> check, given that are stubbed tick_nohz_full_enabled() defined above.

True for the "if" clause, but the "housekeeping_mask" variable is only defined
under CONFIG_NO_HZ_FULL.

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/