Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
From: Greg KH
Date: Fri Jul 10 2015 - 19:28:16 EST
On Fri, Jul 10, 2015 at 11:46:07PM +0200, Pavel Machek wrote:
> On Fri 2015-07-10 14:50:12, Felipe Balbi wrote:
> > Hi,
> >
> > On Thu, Jul 09, 2015 at 11:39:22PM +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > sysfs should contain one value per file. This one has at least two,
> > > with nice english sentence as a bonus.
> > >
> > > root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> > > cat vbus
> > > Vbus off, timeout 1100 msec
> > >
> > > :-(.
> >
> > patches are always welcome.
>
> You'd have to at least describe how you'd like to see it solved if you
> wanted to pretend you maintain it... 2 new attributes? What should be
> their names?
>
> Signed-off-by: Pavel Machek <pavel@xxxxxx>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f6362d7..2e85300 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6900,7 +6900,7 @@ MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER
> M: Felipe Balbi <balbi@xxxxxx>
> L: linux-usb@xxxxxxxxxxxxxxx
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> -S: Maintained
> +S: Odd fixes
> F: drivers/usb/musb/
Don't be a jerk, you are _this_ close to being added to my killfile...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/