Re: [PATCH] bug: Fix build error in V4.2-RC1

From: Larry Finger
Date: Sun Jul 12 2015 - 11:57:02 EST


On 07/12/2015 10:52 AM, Joe Perches wrote:
On Sun, 2015-07-12 at 10:00 -0500, Larry Finger wrote:
If CONFIG_BUG is not defined, then macro __WARN is not defined.
[]
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
[]
@@ -137,6 +137,7 @@ extern void warn_slowpath_null(const char *file, const int line);

+#define __WARN() do {} while (1)

Do you really think WARN should loop forever?

Obviously not. I copied the code in that section for BUG() without thinking.

On to V2 after I get some more feedback.

Thanks,

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/