Re: [PATCH 9/9] MIPS: Remove "__weak" definition from arch-specific linkage.h

[James Hogan]

On 13/07/15 00:12, Bjorn Helgaas wrote:
> "__weak" is defined in include/linux/compiler-gcc.h.  We shouldn't need an
> arch-specific definition.
> 
> Remove the "__weak" definition from arch/mips/include/asm/linkage.h.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

asm/linkage.h is only included from linux/linkage.h, which includes
linux/compiler.h first, so no chance of build problems AFAICT, therefore:

Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>

Thanks
James

> ---
>  arch/mips/include/asm/linkage.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/linkage.h b/arch/mips/include/asm/linkage.h
> index 2767dda..99651b0 100644
> --- a/arch/mips/include/asm/linkage.h
> +++ b/arch/mips/include/asm/linkage.h
> @@ -5,7 +5,6 @@
>  #include <asm/asm.h>
>  #endif
>  
> -#define __weak __attribute__((weak))
>  #define cond_syscall(x) asm(".weak\t" #x "\n" #x "\t=\tsys_ni_syscall")
>  #define SYSCALL_ALIAS(alias, name)					\
>  	asm ( #alias " = " #name "\n\t.globl " #alias)
>

Attachment: signature.asc
Description: OpenPGP digital signature