Re: [PATCH 18/20] staging/lustre/libcfs: get rid of debugfs/lnet/debug_mb

[Oleg Drokin]

On Jul 13, 2015, at 10:43 PM, Greg Kroah-Hartman wrote:

> On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote:
>> On Mon, Jul 06, 2015 at 12:48:56PM -0400, green@xxxxxxxxxxxxxx wrote:
>>> +static int libcfs_param_debug_mb_set(const char *val,
>>> +				     const struct kernel_param *kp)
>>> +{
>>> +	int rc;
>>> +	unsigned num;
>>> +
>>> +	rc = kstrtouint(val, 0, &num);
>>> +	if (rc == -EINVAL)
>>> +		return -EINVAL;
>> 
>> Presumably, this is root only so using num uninitialized is not an
>> information leak.
> 
> But it's not good, this should be a check for rc < 0 to make sure.
> 
> Oleg, can you send a follow-on patch to fix this up?

Sure.
Do you want it now or should I wait till you merge my previous bunch?

Bye,
    Oleg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/