Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

[Arend van Spriel]

On 07/24/2015 07:22 PM, Vineet Gupta wrote:
> On Friday 24 July 2015 08:02 PM, Kalle Valo wrote:
> > Vineet Gupta <Vineet.Gupta1@xxxxxxxxxxxx> writes:
> >
> > > > There's already a generic implementation so use that instead.
> > > > ---
> > > > I'm not sure if the driver usage of atomic_or?() is correct in terms of
> > > > storage size of @val for 64 bit arches.
> > > >
> > > > Assuming LP64 programming model for linux on say x86_64: atomic_or()
> > > > callers in this driver use long (sana 64 bit) storage and pass it to
> > > > atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ?
> > > > ---
> > > > Cc: Brett Rudley <brudley@xxxxxxxxxxxx>
> > > > Cc: Arend van Spriel <arend@xxxxxxxxxxxx>
> > > > Cc: "Franky (Zhenhui) Lin" <frankyl@xxxxxxxxxxxx>
> > > > Cc: Hante Meuleman <meuleman@xxxxxxxxxxxx>
> > > > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> > > > Cc: Pieter-Paul Giesberts <pieterpg@xxxxxxxxxxxx>
> > > > Cc: Daniel Kim <dekim@xxxxxxxxxxxx>
> > > > Cc: linux-wireless@xxxxxxxxxxxxxxx
> > > > Cc: brcm80211-dev-list@xxxxxxxxxxxx
> > > > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > > > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > > > Cc: netdev@xxxxxxxxxxxxxxx
> > > > Cc: linux-arch@xxxxxxxxxxxxxxx
> > > > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > > > Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxxxx>
> > > >
> > > > Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxxxx>
> > What's the plan with this patch? Should I take it to my
> > wireless-drivers-next tree or will someone else take it?
>
>
> Per last discussion on this topic, Arend wanted to discuss abt this with Hante.
> I'm not taking it anyways so feel free to pick it up if you want !

Well, that was before your "timeline" clarification about the generic 
function. One what tree is this patch based?

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/