RE: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw

[Du, Changbin]

> > From: Andrzej Pietrasiewicz [mailto:andrzej.p@xxxxxxxxxxx] Hi,
> >
> > What I mean is that in my opinion it should be done in a separate
> > patch, because the newly introduced USB_VBUS_DRAW_SUSPEND is not
> used
> > anywhere else in your patch. The meaning of this change is "use a
> > symbolic name rather than an explicit number" and it is unrelated to
> > making composite gadget meet usb compliance for vbus draw. In other
> > words, if you don't do this change at all the compliance is still
> > maintained, because the value of USB_VBUS_DRAW_SUSPEND is 2 anyway,
> so
> > what the compiler eventually sees is the same whether the change is
> > made or not.
> >
> > My idea:
> >
> > [PATCHv2 0/2] usb gadget vbus draw compilance
> >    [PATCHv2 1/2] usb: gadget: composite: avoid using a magic number
> >        >> substituting an explicit "2" with USB_VBUS_DRAW_SUSPEND goes
> > here <<
> >    [PATCHv2 2/2] usb: gadget: composite: meet usb compliance for vbus
> draw
> >        >> the rest of your changes go here <<
> >
> > >
Hi, Andrzej. When I try to split into two patches, I realized that it is not applicable.
Because the original code doesn't distinguish different usb types, but new symbols
does. So I cannot make a patch just avoid using a magic number without modify the
control logic.
Hence, I'd prefer doing them in a signal  patch. I will send new modified patch.

Thanks!
Changbin.
> >
> > Andrzej

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/