Re: [PATCH] perf tests: Adding build test for having ending slash in double slash

From: Pawel Moll
Date: Tue Jul 28 2015 - 08:40:59 EST


On Mon, 2015-07-27 at 19:24 +0100, Jiri Olsa wrote:
> I'm getting install error with your patch:
>
> [jolsa@krava perf]$ rm -rf /tmp/krava/ && make install prefix=/tmp/krava
>
> SNIP
>
> LINK perf
> INSTALL binaries
> INSTALL tests
> install: cannot create directory ââ: No such file or directory
> install: target ââ is not a directory: No such file or directory
> ln: failed to access â/perfâ: No such file or directory
> Makefile.perf:492: recipe for target 'install-tools' failed
> make[1]: *** [install-tools] Error 1
> make[1]: *** Waiting for unfinished jobs....
> Makefile:87: recipe for target 'install' failed
> make: *** [install] Error 2
>
> somethings wrong with install targets dealing with bindir_SQ

Interesting. Building from a perf-tar-src-pkg tarball works:

$ rm -rf /tmp/krava/ && make install prefix=/tmp/krava
[...]
LINK perf
LINK libperf-gtk.so
INSTALL GTK UI
INSTALL binaries
INSTALL tests
INSTALL libexec
INSTALL perf-archive
INSTALL perf-with-kcore
INSTALL perl-scripts
INSTALL python-scripts
INSTALL perf_completion-script

but it breaks indeed the way you pointed out when building in-tree...

Having a look now.

Pawel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/