RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

[Shenwei Wang]

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx]
> Sent: 2015年7月27日 19:48
> To: Wang Shenwei-B38339
> Cc: jason@xxxxxxxxxxxxxx; Huang Yongcai-B20788;
> linux-kernel@xxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; shawn.guo@xxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup
> sources
> 
> On Mon, Jul 27, 2015 at 02:50:15PM +0000, Shenwei Wang wrote:
> > The following structure is currently used in both drivers. The members
> > "gpc_base/ wakeup_sources/enabled_irqs" are now shared to PM driver.
> > And the macro IMR_NUM will be referred by both drivers too.
> >
> > struct imx_gpcv2_irq {
> > 	spinlock_t lock;
> > 	void __iomem *gpc_base;
> 
> So this is the virtual base used by both irqchip and pm driver, and the lock is for
> register access protection, right?  If so, we can define gpc as a syscon device,
> and access it from both drivers with regmap.

Regmap can be a solution too.

> > 	u32 wakeup_sources[IMR_NUM];
> 
> This should be an irqchip internal data and exported to external users like pm
> code with an interface like imx_gpcv2_get_wakeup_sources().

Okay.

> > 	u32 enabled_irqs[IMR_NUM];


> I do not see how this is used in pm driver.
> 
> > 	u32 cpu2wakeup;
> 
> The only use of this in pm driver is to unmask interrupt #32 during initialization.
> Why cannot it be done in irqchip driver initialization?

Right. This line should be moved to irqchip driver.

Thanks.
Shenwei 

> Shawn
> 
> > };