Re: [PATCH v8 09/21] x86/paravirt: Align paravirt thunk functions at 16-byte boundaries

[Josh Poimboeuf]

On Tue, Jul 28, 2015 at 08:23:04AM -0700, Andy Lutomirski wrote:
> On Tue, Jul 28, 2015 at 7:47 AM, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > Paravirt thunk functions aren't aligned, which can impact performance
> > and is inconsistent with gcc-generated functions.
> >
> > Align them at 16-byte boundaries to be consistent with gcc functions.
> 
> IMO stackvalidate shouldn't warn about this.  We've discussed dropping
> the alignment requirement entirely, since it seems to have little
> benefit on modern CPUs.

Stackvalidate didn't actually find this alignment issue.  I just noticed
it when fixing the frame pointer issue.  If alignment no longer helps
with performance on modern CPUS, it's fine to drop this patch.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/