Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

[Alexander Shishkin]

Chunyan Zhang <zhang.lyra@xxxxxxxxx> writes:

> The code has already been submitted like I said in the earlier emails,
> you may refer [1].
>
> Thanks,
> Chunyan
>
> [1] https://lkml.org/lkml/2015/2/4/729

This code does the following (pasting from that patch):

in stm_probe():

drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);

... something irrelevant ...

ret = clk_prepare_enable(drvdata->clk);

... something irrelevant ...

clk_disable_unprepare(drvdata->clk);

... something irrelevant ...

drvdata->clk = adev->pclk;

How is this supposed to even work?

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/