Re: [PATCH 3/4] KVM: i8254: remove unnecessary irqchip_in_kernel check

[Paolo Bonzini]

On 30/07/2015 06:36, Steve Rutherford wrote:
> On Wed, Jul 29, 2015 at 03:28:57PM +0200, Paolo Bonzini wrote:
>> > The PIT is only created if irqchip_in_kernel returns true, so the
>> > check is superfluous.
> I poked around. Looks to me like the existence of an IOAPIC is not
> checked on the creation of the in-kernel PIT.

You're right, and presumably it's also legal to create the PIT before
KVM_CREATE_IRQCHIP.

> Userspace might limit itself to
> that scenario (PIT implies IOAPIC in-kernel), but that isn't enforced at PIT
> creation.

I'll play with the "PIT without IOAPIC" scenario and see if something
breaks badly with this patch.  From reading the code it seems like it
should not introduce any problems (oopses or similar), but I'll set this
patch aside for now.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/