Re: [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile

From: Mark Brown
Date: Sat Aug 01 2015 - 06:59:38 EST


On Sat, Aug 01, 2015 at 04:42:27AM +0900, Masahiro Yamada wrote:
> Kbuild descends into drivers/base/regmap/ only when CONFIG_REGMAP
> is enabled. (see drivers/base/Makefile)
>
> $(CONFIG_REGMAP) in drivers/base/regmap/Makefile always evaluates
> to 'y'.

> -obj-$(CONFIG_REGMAP) += regmap.o regcache.o
> -obj-$(CONFIG_REGMAP) += regcache-rbtree.o regcache-lzo.o regcache-flat.o
> +obj-y += regmap.o regcache.o
> +obj-y += regcache-rbtree.o regcache-lzo.o regcache-flat.o
> obj-$(CONFIG_DEBUG_FS) += regmap-debugfs.o
> obj-$(CONFIG_REGMAP_AC97) += regmap-ac97.o
> obj-$(CONFIG_REGMAP_I2C) += regmap-i2c.o

OTOH it does make the Makefile look a bit neater to have everything
selected by config option... is there a practical cost here?

Attachment: signature.asc
Description: Digital signature