Re: [PATCH] watchdog: Fix race on single cpu boot

From: Ulrich Obergfell
Date: Sun Aug 02 2015 - 07:09:51 EST



Peter,

>> I posted the patch set here:
>>
>> https://lkml.org/lkml/2015/8/1/64
>> https://lkml.org/lkml/2015/8/1/65
>> https://lkml.org/lkml/2015/8/1/66
>> https://lkml.org/lkml/2015/8/1/67
>> https://lkml.org/lkml/2015/8/1/68
>
> If only you didn't use lkml.org links, that site is flaky beyond
> unusable.
>
> Please use lkml.kernel.org/r/$msgid, that way people actually have a
> chance of getting a working link and/or finding it in their local
> archive.

I apologize for the inconvenience. The following links redirect to marc.info:

- [PATCH 0/4] watchdog: avoid races in watchdog_nmi_{en|disable} functions
lkml.kernel.org/r/1438433365-2979-1-git-send-email-uobergfe@xxxxxxxxxx

- [PATCH 1/4] watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads()
lkml.kernel.org/r/1438433365-2979-2-git-send-email-uobergfe@xxxxxxxxxx

- [PATCH 2/4] watchdog: introduce watchdog_suspend() and watchdog_resume()
lkml.kernel.org/r/1438433365-2979-3-git-send-email-uobergfe@xxxxxxxxxx

This part of the series has already received a comment. The suggestion is
to introduce different function names to avoid confusion with the watchdog
subsystem, so I propose

lockup_detector_suspend() instead of watchdog_suspend()
lockup_detector_resume() instead of watchdog_resume()

which would be consistent with the existing name lockup_detector_init().

- [PATCH 3/4] watchdog: use park/unpark functions in update_watchdog_all_cpus()
lkml.kernel.org/r/1438433365-2979-4-git-send-email-uobergfe@xxxxxxxxxx

- [PATCH 4/4] watchdog: use suspend/resume interface in fixup_ht_bug()
lkml.kernel.org/r/1438433365-2979-5-git-send-email-uobergfe@xxxxxxxxxx


Regards,

Uli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/