Re: [PATCH] mm: add the block to the tail of the list in expand()

From: Dave Hansen
Date: Mon Aug 03 2015 - 00:10:16 EST


On 08/02/2015 07:05 PM, Xishi Qiu wrote:
>> > Also, this might not do very much good in practice. If you are
>> > splitting a high-order page, you are doing the split because the
>> > lower-order lists are empty. So won't that list_add() be to an empty
>
> I made a mistake, you are right, all the lower-order lists are empty,
> so it is no sense to add to the tail.

I actually tested this experimentally and the lists are not always
empty. It's probably __rmqueue_smallest() vs. __rmqueue_fallback() logic.

In any case, you might want to double-check.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/