Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors
From: Thomas Gleixner
Date: Mon Aug 03 2015 - 05:40:28 EST
On Mon, 3 Aug 2015, Rusty Russell wrote:
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
> > +
> > + /* Some systems map "vectors" to interrupts weirdly. Not us! */
> > + __this_cpu_write(vector_irq[FIRST_EXTERNAL_VECTOR + irq, irq);
>
> Missing ].
Doh.
> [ 17.751889] do_IRQ: 0.33 No irq handler for vector (irq -1)
>
> You broke interrupts :(
Right, because I missed the other place which fiddles with
interrupts. Does the patch below fix the issue?
Thanks,
tglx
---------------->
Index: tip/arch/x86/lguest/boot.c
===================================================================
--- tip.orig/arch/x86/lguest/boot.c
+++ tip/arch/x86/lguest/boot.c
@@ -841,8 +841,7 @@ static int lguest_enable_irq(struct pci_
/* We literally use the PCI interrupt line as the irq number. */
pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &line);
- irq_set_chip_and_handler_name(line, &lguest_irq_controller,
- handle_level_irq, "level");
+ lguest_setup_irq(line);
dev->irq = line;
return 0;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/