Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl

[Dan Carpenter]

On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote:
> On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote:
> > On Mon, Aug 03, 2015 at 11:18:31AM +0000, Shah, Yash (Y.) wrote:
> > > From: Yash Shah <yshah1@xxxxxxxxxxx>
> > > 
> > > Fixed code indentation warning as detected by checkpatch.pl.
> > > 
> > > Signed-off-by: Yash Shah <yshah1@xxxxxxxxxxx>
> > 
> > Defines aren't allowed in .c files anyway.
> 
> The kernel source tree disagrees with you
> 
> $ git grep "^\s*#\s*define\b" -- "*.c" | wc -l
> 175830

Duh.  Sorry.  I meant ifdefs.  I'm sure you can find lots of examples
of those too, but this code would be cleaner without the ifdefs.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/