Re: [PATCH v6 6/8] arm64: dts: add SRAM, MHU mailbox and SCPI support on Juno

[Sudeep Holla]

On 03/08/15 12:46, Jon Medhurst (Tixy) wrote:
> On Mon, 2015-08-03 at 12:23 +0100, Liviu Dudau wrote:
> > On Fri, Jul 31, 2015 at 06:43:09PM +0100, Sudeep Holla wrote:
> > > This patch adds support for the MHU mailbox peripheral used on Juno by
> > > application processors to communicate with remote SCP handling most of
> > > the CPU/system power management. It also adds the SRAM reserving the
> > > shared memory and SCPI message protocol using that shared memory.
> > >
> > > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> > > Acked-by: Liviu Dudau <Liviu.Dudau@xxxxxxx>
> > > Cc: Jon Medhurst (Tixy) <tixy@xxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/arm/juno-base.dtsi | 54 ++++++++++++++++++++++++++++++++++
> > >   1 file changed, 54 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > index e3ee96036eca..c624208edef6 100644
> > > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> > > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> [...]
> > > +	scpi {
> > > +		compatible = "arm,scpi";
> > > +		mboxes = <&mailbox 1>;
> > > +		shmem = <&cpu_scp_hpri>;
> > > +
> > > +		clocks {
> > > +			compatible = "arm,scpi-clocks";
> > > +
> > > +			scpi_dvfs: scpi_clocks@0 {
> > > +				compatible = "arm,scpi-dvfs-clocks";
> > > +				#clock-cells = <1>;
> > > +				clock-indices = <0>, <1>, <2>;
> > > +				clock-output-names = "atlclk", "aplclk","gpuclk";
> > > +			};
> > > +			scpi_clk: scpi_clocks@3 {
> > > +				compatible = "arm,scpi-variable-clocks";
> > > +				#clock-cells = <1>;
> > > +				clock-indices = <3>, <4>;
> > > +				clock-output-names = "pxlclk0", "pxlclk1";
> > > +			};
> > > +		};
> > > +	};
> > > +
> >
> > Sorry for noticing this after the ACK, is there any reason why the scpi node is not inside
> > the juno-clocks.dtsi file?
>
> Because SCPI is not just about clocks? Just happens that these first
> patches are but there's thermal sensors and other things as well.

I think we cross posted. Anyways I completely agree with you.
However I wanted the clock nodes to be put in juno-clock.dtsi but got
into horrible issue with the way we include headers. It may need some
reworking to get that working.

The idea was:
/* in juno-base.dtsi */
SCPI: scpi {
	compatible = "arm,scpi";
	mboxes = <&mailbox 1>;
	shmem = <&cpu_scp_hpri>;
	...
};
/* in juno-clock.dtsi */
&SCPI {
        clocks {
                compatible = "arm,scpi-clocks";
                scpi_dvfs: scpi_clocks@0 {
                        compatible = "arm,scpi-dvfs-clocks";
                        #clock-cells = <1>;
                        clock-indices = <0>, <1>, <2>;
                        clock-output-names = "atlclk","aplclk","gpuclk";
                };
};

I will look at that when I get some time. There are many DTS files
already using something similar.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/