Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL)

[Murali Karicheri]

On 07/31/2015 12:20 PM, Viresh Kumar wrote:
> On 31-07-15, 11:04, Murali Karicheri wrote:
> > On 07/31/2015 04:38 AM, Viresh Kumar wrote:
> > > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> > > is no need to do that again from its callers. Drop it.
> >
> > IS_ERR_OR_NULL() is defined as
> >
> > static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
> > {
> >          return !ptr || IS_ERR_VALUE((unsigned long)ptr);
> > }
> >
> > So the unlikely() applies only to second part. Wouldn't that be a
> > problem for optimization?
>
> This is what the first patch of the series does:
>
> http://permalink.gmane.org/gmane.linux.kernel/2009151
Assuming the above change is merged, this patch looks good.

Acked-by: Murali Karicheri <m-karicheri2@xxxxxx>

--
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/