Re: perf eBPF patch ordering. was: Re: perf test LLVM was: Re: [GIT PULL 00/39] perf tools: filtering events using eBPF programs
From: Arnaldo Carvalho de Melo
Date: Tue Aug 04 2015 - 11:56:11 EST
Em Tue, Aug 04, 2015 at 06:39:39PM +0800, Wangnan (F) escreveu:
> Just realized that 'tempnam' is not safe. Switch to mkdtemp. Please see the
> new version:
>
> https://github.com/WangNan0/linux/commit/bd02aed760c4a35fec4483d24c158799f05f6f9e
>
> and pull request update:
>
> The following changes since commit 922cc21746202956acb41c89a6190bb50805fa31:
>
> perf tools: Introduce llvm config options (2015-07-31 12:17:50 -0300)
>
> are available in the git repository at:
>
> https://github.com/WangNan0/linux.git ebpf
Ok, but I am checking patch by patch to see if the changes I made are
kept, and for the first one, it wasn't (the second one is the cset in
your newest github tree: cceb9fed5722dc78730e7ed739b75ece4476740f, the
other is for my tree, that was rebased, but the contents should be the
same as what is in my perf/ebpf branch in git.kernel.org), I'm keeping
my version, will check the others:
[acme@felicio linux]$ gdiff f696ecb01b519ae8273b2876b45678b920767f8a cceb9fed5722dc78730e7ed739b75ece4476740f
--- /tmp/gdiff.f696ecb01b519ae8273b2876b45678b920767f8a.y3ojwYFV0g 2015-08-04 12:53:29.898525129 -0300
+++ /tmp/gdiff.cceb9fed5722dc78730e7ed739b75ece4476740f.1ximzKA8ST 2015-08-04 12:53:29.900525095 -0300
@@ -1,4 +1,4 @@
-commit f696ecb01b519ae8273b2876b45678b920767f8a
+commit cceb9fed5722dc78730e7ed739b75ece4476740f
Author: Wang Nan <wangnan0@xxxxxxxxxx>
Date: Thu Jun 11 10:31:09 2015 +0000
@@ -14,20 +14,8 @@
source code path is injected into shell command using environment
variable using force_set_env().
- Commiter notice:
-
- When building with DEBUG=1 we get a compiler error that gets fixed with
- the same approach described in commit b236512280fb:
-
- perf kmem: Fix compiler warning about may be accessing uninitialized variable
-
- The last argument to strtok_r doesn't need to be initialized, its
- just a placeholder to make this routine reentrant, but gcc doesn't know
- about that and complains, breaking the build, fix it by setting it to
- NULL.
-
Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
- Acked-by: Alexei Starovoitov <ast@xxxxxxxxxxxx>
+ Cc: Alexei Starovoitov <ast@xxxxxxxxxxxx>
Cc: Brendan Gregg <brendan.d.gregg@xxxxxxxxx>
Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxx>
@@ -43,7 +32,7 @@
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
diff --git a/tools/perf/util/llvm-utils.c b/tools/perf/util/llvm-utils.c
-index 472e8cd69361..7d01fcc23aa8 100644
+index 472e8cd69361..08e2eb1354e3 100644
--- a/tools/perf/util/llvm-utils.c
+++ b/tools/perf/util/llvm-utils.c
@@ -43,3 +43,228 @@ int perf_llvm_config(const char *var, const char *value)
@@ -55,7 +44,7 @@
+search_program(const char *def, const char *name,
+ char *output)
+{
-+ char *env, *path, *tmp = NULL;
++ char *env, *path, *tmp;
+ char buf[PATH_MAX];
+ int ret;
+
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/