Re: [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver

[Dave Gerlach]

On 07/20/2015 01:16 AM, Tony Lindgren wrote:
> * Dave Gerlach <d-gerlach@xxxxxx> [150717 13:59]:
> > +
> > +/* Public functions */
> ...
> > +EXPORT_SYMBOL_GPL(wkup_m3_set_mem_type);
> > +EXPORT_SYMBOL_GPL(wkup_m3_set_resume_address);
> > +EXPORT_SYMBOL_GPL(wkup_m3_request_pm_status);
> > +EXPORT_SYMBOL_GPL(wkup_m3_prepare_low_power);
> > +EXPORT_SYMBOL_GPL(wkup_m3_finish_low_power);
>
> I think you can avoid exporting these SoC specific functions
> by just exporting wkup_m3_request() and wkup_m3_free() type
> functions with a data structure containing the necessary
> function pointers.

Ok thanks for the comment, I can try that change out, I agree it 
probably isn't necessary to export so much.

Regards,
Dave

> Regards,
>
> Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/