Re: [PATCH] zram: Replace pr_* with dev_*

From: Joe Perches
Date: Tue Aug 04 2015 - 21:16:37 EST


On Wed, 2015-08-05 at 08:57 +0900, Sergey Senozhatsky wrote:
> On (08/05/15 08:42), Sergey Senozhatsky wrote:
> > what's the benefit?
>
> and apart from that I don't understand why do you replace some
> pr_info() with dev_warn(). f.e.

And besides that, the formats should not be changed
and still require a '\n' termination to avoid
possible interleaving.

> [..]
> > > if (!zcomp_set_max_streams(zram->comp, num)) {
> > > - pr_info("Cannot change max compression streams\n");
> > > + dev_warn(dev, "Cannot change max compression streams to %d",
> > > + num);

etc...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/