Re: [PATCH] i2c: allow specifying separate wakeup interrupt in device tree

[Tony Lindgren]

* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> [150803 13:05]:
> On Mon, Aug 03, 2015 at 03:21:21AM -0700, Tony Lindgren wrote:
> > 
> > Hmm why do we need the check for if (device_can_wakeup(&client->dev)))?
> 
> Because of the code in device_wakeup_attach_irq():
> 
> 	ws = dev->power.wakeup;
> 	if (!ws) {
> 		dev_err(dev, "forgot to call call device_init_wakeup?\n");
> 		return -EINVAL;
> 	}

OK :) 

> > Also wondering about the dev vs &client->dev usage here.. But I take
> > you have checked that we end up calling the runtime PM calls of the
> > client instead of the i2c bus controller :)
> 
> dev *is* clent->dev in this context:
> 
> 	struct i2c_client *client = i2c_verify_client(dev);

OK thanks for confirming that.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/