Re: [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe

[Kishon Vijay Abraham I]

Hi,

On Tuesday 04 August 2015 09:36 PM, Felipe Balbi wrote:
> On Tue, Aug 04, 2015 at 08:50:41PM +0530, Kishon Vijay Abraham I wrote:
>> No functional change. Previously omap_control_phy_power() was used to power
> 
> there is a slight functional change. You moved PHY power off from before
> to after pm_runtime_enable(), clk_prepare_enable() and creation of the
> PHY device. That ought to have a slight impact on how the driver
> behaves.

okay. I'll modify the commit log. I think it won't impact the functionality as
such since the ->init and ->power_on callbacks won't be invoked at that point.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/